Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(prefer-immutable-types): allow overriding options based on where the type is declared #804

Open
wants to merge 1 commit into
base: 04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs
Choose a base branch
from
Open

feat(prefer-immutable-types): allow overriding options based on where the type is declared #804

wants to merge 1 commit into from

Conversation

RebeccaStevens
Copy link
Collaborator

@RebeccaStevens RebeccaStevens commented Apr 14, 2024 •
edited
Loading

Fix #800

@RebeccaStevens
Copy link
Collaborator Author

RebeccaStevens commented Apr 14, 2024 •
edited
Loading

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @RebeccaStevens and the rest of your teammates on Graphite Graphite

@RebeccaStevens RebeccaStevens mentioned this pull request Apr 14, 2024
Open
@RebeccaStevens RebeccaStevens marked this pull request as ready for review April 14, 2024 14:04
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from 0a6bd90 to f31eb30 Compare April 14, 2024 14:13
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 0130f0f to 63f36f3 Compare April 14, 2024 14:13
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from f31eb30 to c24ea84 Compare April 14, 2024 14:16
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 63f36f3 to d246ac3 Compare April 14, 2024 14:16
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from c24ea84 to bf25112 Compare April 14, 2024 14:27
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from d246ac3 to 7c09967 Compare April 14, 2024 14:27
@RebeccaStevens
Copy link
Collaborator Author

We probably want to bump the minimum ts version up to 4.7

@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from bf25112 to 8bfc725 Compare April 15, 2024 06:54
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 7c09967 to d33e2c7 Compare April 15, 2024 06:54
@RebeccaStevens RebeccaStevens mentioned this pull request Apr 15, 2024
Closed
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from 8bfc725 to 20f7137 Compare April 15, 2024 08:33
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from d33e2c7 to 78839d6 Compare April 15, 2024 08:33
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from 20f7137 to 61e4e86 Compare April 16, 2024 09:34
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 78839d6 to a1a2526 Compare April 16, 2024 09:34
@RebeccaStevens RebeccaStevens mentioned this pull request Apr 16, 2024
Open
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from 61e4e86 to 90bb5eb Compare April 17, 2024 12:16
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from a1a2526 to f62f410 Compare April 17, 2024 12:16
This was referenced Apr 18, 2024
Open
Open
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from 90bb5eb to 71364aa Compare April 22, 2024 12:33
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from f62f410 to 414f358 Compare April 22, 2024 12:33
@RebeccaStevens RebeccaStevens mentioned this pull request Apr 22, 2024
Open
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from 71364aa to 4a927d8 Compare April 22, 2024 15:25
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 414f358 to 389d79d Compare April 22, 2024 15:25
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from 4a927d8 to 8387695 Compare April 22, 2024 16:03
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 389d79d to dd561f5 Compare April 22, 2024 16:03
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_functional-parameters_allow_overriding_options_based_on_where_the_function_type_is_declared branch from 8387695 to 854b721 Compare April 30, 2024 06:05
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from e14960e to c873a3d Compare June 19, 2024 03:50
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs branch from 83998a4 to b3a72ab Compare June 19, 2024 07:14
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from c873a3d to 09a1947 Compare June 19, 2024 07:14
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs branch from b3a72ab to 690af4c Compare June 19, 2024 08:06
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 09a1947 to 666d8c3 Compare June 19, 2024 08:06
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs branch from 690af4c to 313d2ca Compare June 19, 2024 08:20
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 666d8c3 to 43e270f Compare June 19, 2024 08:20
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs branch from 313d2ca to 31f2f02 Compare June 19, 2024 10:22
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 43e270f to 29ef1f0 Compare June 19, 2024 10:22
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs branch from 31f2f02 to 326260e Compare June 19, 2024 11:02
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 29ef1f0 to e739b5b Compare June 19, 2024 11:02
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs branch from 326260e to 4064dca Compare June 19, 2024 11:10
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from e739b5b to 8c42a0a Compare June 19, 2024 11:10
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs branch from 4064dca to 8432114 Compare June 24, 2024 11:51
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 8c42a0a to eda6c89 Compare June 24, 2024 11:51
@RebeccaStevens RebeccaStevens mentioned this pull request Jun 24, 2024
Open
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs branch from 8432114 to ca2dc58 Compare June 30, 2024 07:11
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from eda6c89 to f42398c Compare June 30, 2024 07:11
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs branch from ca2dc58 to 5498b2b Compare June 30, 2024 08:25
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from f42398c to d19e712 Compare June 30, 2024 08:25
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs branch from 5498b2b to ad39239 Compare July 5, 2024 09:16
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from d19e712 to 0f0ff14 Compare July 5, 2024 09:16
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs branch from ad39239 to 0ddbf09 Compare July 6, 2024 02:25
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 0f0ff14 to 737b653 Compare July 6, 2024 02:25
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs branch from 0ddbf09 to 82f1729 Compare July 6, 2024 03:44
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from 737b653 to f742b89 Compare July 6, 2024 03:44
@RebeccaStevens RebeccaStevens force-pushed the 04-18-feat_functional-parameters_change_options_in_recommended_and_lite_configs branch from 82f1729 to 31ae82e Compare July 10, 2024 14:41
@RebeccaStevens RebeccaStevens force-pushed the 04-15-feat_prefer-immutable-types_allow_overriding_options_based_on_where_the_type_is_declared branch from f742b89 to b574f86 Compare July 10, 2024 14:41
@RebeccaStevens RebeccaStevens mentioned this pull request Jul 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@RebeccaStevens